Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QC mapping in sales/purchase with same items #42219

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: QC mapping in sales/purchase with same items #42219

wants to merge 4 commits into from

Conversation

Nihantra-Patel
Copy link
Contributor

Version: 15 & 14

fixes: #42213

Before:

  • When I add the same item in the Purchase Receipt/Delivery Note Item table and create a Quality Inspection for both, it adds the same Quality Inspection for each. When submitting the Quality Inspection, it sets the same reference in both child tables in the Purchase Invoice/Delivery Note.
before_qc.mp4

After:

  • fixed for the sales/purchase process.
after_qc.mp4

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Jul 8, 2024
@Nihantra-Patel Nihantra-Patel marked this pull request as draft July 8, 2024 13:04
@Nihantra-Patel Nihantra-Patel marked this pull request as ready for review July 10, 2024 06:58
@stale stale bot added the inactive label Jul 27, 2024
@frappe frappe deleted a comment from stale bot Jul 27, 2024
@Nihantra-Patel Nihantra-Patel removed needs-tests This PR needs automated unit-tests. inactive labels Jul 27, 2024
@stale stale bot added the inactive label Aug 14, 2024
@frappe frappe deleted a comment from stale bot Aug 14, 2024
@stale stale bot removed the inactive label Aug 14, 2024
@stale stale bot added the inactive label Sep 1, 2024
@frappe frappe deleted a comment from stale bot Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quality Inspection not mapping item propely
1 participant
@Nihantra-Patel